This repository has been archived by the owner on May 16, 2018. It is now read-only.
Fix pcre segmentation fault in Zend_Db_Statement #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to add unit test |
|
Test added, causes the segmentation fault in old code, passes in new one. |
ghost
force-pushed
the
db_regexp_fix
branch
7 times, most recently
from
bb80c6e
to
d25f64d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered some segmentation faults on long queries (>10.000 characters) containing double quotes at this place. Marking the capture as ignored fixed it. After all it is not used anyway.